Remove Opcode Validation When Specifying a RelatedActivityId #38347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
sywhang
approved these changes
Jun 24, 2020
|
Hello @brianrob! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 17, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 17, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 17, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 17, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 17, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 17, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 17, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 17, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 17, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 17, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 17, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 17, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 18, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 18, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 18, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 18, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 18, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
github-actions bot
pushed a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 19, 2020
…38347) * Remove opcode validation when specifying relatedActivityId. * Remove test that is no longer needed.
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38223.
The existing Opcode validation is overly strict, and isn't required by any of the logging systems that we support. There are some semantics defined on the consumption side for particular opcodes, but that doesn't preclude use of additional opcodes.
Right now, WCF client events are broken because they use a wider set of opcodes when specifying a RelatedActivityID.
cc: @mconnew